Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve the inconsistent type issue in JsModule #8939

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: resolve the inconsistent type issue in JsModule #8939

merged 2 commits into from
Jan 22, 2025
+14 −8

Conversation

shulaoda
Copy link
Collaborator

@shulaoda shulaoda commented Jan 6, 2025

Summary

closes #8937

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda requested a review from SyMind January 6, 2025 03:51
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jan 6, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 026052f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/677b58da3bb05400086417dd

@SoonIter SoonIter mentioned this pull request Jan 6, 2025
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8939 will not alter performance

Comparing shulaoda:fix/type-js-module (026052f) with main (f81f1c7)

Summary

✅ 3 untouched benchmarks

@shulaoda shulaoda marked this pull request as draft January 6, 2025 04:10
@shulaoda shulaoda marked this pull request as ready for review January 6, 2025 04:25
SoonIter
SoonIter previously approved these changes Jan 7, 2025
View reviewed changes
packages/rspack/src/Module.ts Show resolved Hide resolved
@SoonIter SoonIter dismissed their stale review January 7, 2025 06:04

comment

SyMind
SyMind approved these changes Jan 21, 2025
View reviewed changes
packages/rspack/src/Module.ts Show resolved Hide resolved
@SoonIter SoonIter merged commit 9696d62 into web-infra-dev:main Jan 22, 2025
30 checks passed
@adrians5j
Copy link

Thanks! 😊

@shulaoda shulaoda deleted the fix/type-js-module branch January 22, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@SyMind SyMind SyMind approved these changes

@SoonIter SoonIter SoonIter left review comments

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TS Errors When Running With skipLibCheck: false
5 participants
@shulaoda @adrians5j @chenjiahan @SyMind @SoonIter